Warn when using blink_simple without PICO_DEFAULT_LED_PIN #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink_simple won't do anything without PICO_DEFAULT_LED_PIN, so raise a warning similar to other examples that rely on PICO_DEFAULT_LED_PIN (eg blinky, hello_pio)
will-v-pi
added a commit
to raspberrypi/pico-vscode
that referenced
this pull request
Jan 15, 2025
This will be fixed if raspberrypi/pico-examples#598 is merged Fixes #152
peterharperuk
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
blink_simpleexample won't do anything withoutPICO_DEFAULT_LED_PINdefined, so the compilation should raise a warning similar to other examples that rely onPICO_DEFAULT_LED_PIN(egblinky,hello_pio) when it's not defined.Prompted by raspberrypi/pico-vscode#152